Skip to content

Conversation

@williamberman
Copy link
Contributor

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 25, 2023

The documentation is not available anymore as the PR was closed or merged.

@williamberman williamberman force-pushed the pipeline_tests_mixin_num_images_per_prompt branch 2 times, most recently from 5ea3d11 to fa35a2c Compare February 26, 2023 01:53
@williamberman williamberman force-pushed the pipeline_tests_mixin_num_images_per_prompt branch from fa35a2c to 1ae7ac3 Compare February 26, 2023 03:18
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 🔥

@williamberman
Copy link
Contributor Author

If we merge #2502 , I can change these tests to use batch_params

@sayakpaul
Copy link
Member

If we merge #2502 , I can change these tests to use batch_params

Yeah worth waiting for that one to get merged meanwhile then.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice refactor! Thanks a lot!

Comment on lines -401 to -412
expected_slice = np.array(
[
0.9980,
0.9997,
0.0023,
0.0029,
0.9997,
0.9985,
0.9997,
0.0010,
0.9995,
]
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We lost this test, but I agree it's not a num_images_per_prompt test :)

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@patrickvonplaten
Copy link
Contributor

@williamberman happy to get this one in soon :-)

@williamberman
Copy link
Contributor Author

@williamberman happy to get this one in soon :-)

Yeah going to make some small changes because we merged the other PR with batch_param then merge today

@williamberman williamberman merged commit a72a057 into huggingface:main Mar 3, 2023
mengfei25 pushed a commit to mengfei25/diffusers that referenced this pull request Mar 27, 2023
* attend and excite batch test causing timeouts

* move test num_images_per_prompt to pipeline mixin

* style

* prompt_key -> self.batch_params
w4ffl35 pushed a commit to w4ffl35/diffusers that referenced this pull request Apr 14, 2023
* attend and excite batch test causing timeouts

* move test num_images_per_prompt to pipeline mixin

* style

* prompt_key -> self.batch_params
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* attend and excite batch test causing timeouts

* move test num_images_per_prompt to pipeline mixin

* style

* prompt_key -> self.batch_params
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* attend and excite batch test causing timeouts

* move test num_images_per_prompt to pipeline mixin

* style

* prompt_key -> self.batch_params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants