Skip to content

Conversation

@stevhliu
Copy link
Member

@stevhliu stevhliu commented Mar 1, 2023

This PR moves the relevant code example for text-to-image training with LoRA from the blog to the docs. To get it to fit in with the existing docs on LoRA, I had to rearrange the structure a bit, so now it shows training and inference for both text-to-image and DreamBooth. Let me know if I've forgotten anything!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 1, 2023

The documentation is not available anymore as the PR was closed or merged.

@sayakpaul
Copy link
Member

@stevhliu thanks for this. Would you instead like to iterate on https://huggingface.co/docs/diffusers/training/lora ? I think that might be better.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can we here again link to the automatically generated google colab?

@patrickvonplaten
Copy link
Contributor

Or does it work out of the box?

@patrickvonplaten
Copy link
Contributor

@yiyixuxu please take a look here as wel

@stevhliu
Copy link
Member Author

stevhliu commented Mar 2, 2023

Would you instead like to iterate on https://huggingface.co/docs/diffusers/training/lora ?

Hmm, not sure I understand. 😅 These changes are being applied to the lora.mdx docs.

Nice, can we here again link to the automatically generated google colab?

Yes, I just added the auto-generated Colab link which should be live once merged!

@sayakpaul
Copy link
Member

Hmm, not sure I understand. 😅 These changes are being applied to the lora.mdx docs.

My bad, @stevhliu! Please disregard.

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Mar 3, 2023

@patrickvonplaten yes it links itself

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thank you @stevhliu

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Mar 4, 2023

@stevhliu feel free to merge this one in whenever

@stevhliu stevhliu merged commit 62bea2d into huggingface:main Mar 6, 2023
@stevhliu stevhliu deleted the add-lora-blog-to-doc branch March 6, 2023 21:45
mengfei25 pushed a commit to mengfei25/diffusers that referenced this pull request Mar 27, 2023
…e#2527)

* include text2image lora training in docs

* 🖍 apply feedback

* 🖍 minor edits
w4ffl35 pushed a commit to w4ffl35/diffusers that referenced this pull request Apr 14, 2023
…e#2527)

* include text2image lora training in docs

* 🖍 apply feedback

* 🖍 minor edits
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…e#2527)

* include text2image lora training in docs

* 🖍 apply feedback

* 🖍 minor edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants