-
Couldn't load subscription status.
- Fork 6.5k
[docs] Performance tutorial #2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
docs/source/en/_toctree.yml
Outdated
| title: Overview | ||
| - local: using-diffusers/write_own_pipeline | ||
| title: Understanding models and schedulers | ||
| - local: stable_diffusion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we give a bit less generic name to this doc since we're discussing optimization specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sayakpaul I think that's just the file name, the name of the doc is "Improve DiffusionPipeline performance" -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah and this way we don't break any links to this doc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually like to keep it a main doc page for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! I really like the isolation of the information.
@patrickvonplaten should we consider updating this doc with the latest goodies we support from diffusers:
- VAE tiling (for a higher-resolution generation without blowing up memory)
- CPU offloading
- UniPCMultistepScheduler (fastest scheduler)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you!!
docs/source/en/_toctree.yml
Outdated
| title: Overview | ||
| - local: using-diffusers/write_own_pipeline | ||
| title: Understanding models and schedulers | ||
| - local: stable_diffusion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sayakpaul I think that's just the file name, the name of the doc is "Improve DiffusionPipeline performance" -
| ``` | ||
| ```python | ||
| pipeline = pipeline.to("cuda") | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update this guide with enable_model_cpu_offload()? cc @patrickvonplaten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the doc page - would like to keep it as a main page for now though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating so much here
* update performance tutorial * fix divs * oops forgot to close tag * apply feedback * apply feedback * apply feedback * align doc title
* update performance tutorial * fix divs * oops forgot to close tag * apply feedback * apply feedback * apply feedback * align doc title
This PR updates the Stable Diffusion guide to Improve DiffusionPipeline performance tutorial. Some of the updates include:
StableDiffusionPipelinefor the more genericDiffusionPipelineDiffusionPipelinefirst before trying to optimize it[[open-in-colab]]tag and removes the link to the Colab notebook