Initial draft of Core ML docs #2987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Closed
stevhliu
reviewed
Apr 5, 2023
There was a problem hiding this comment.
Super cool doc! 🍎
My main high-level feedback is to center the doc intro a bit more around CoreML and, if possible, skip ahead to the technical steps for how to do something. I think this'll be a better user experience and help them get the info they need faster :)
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
pcuenca
commented
Apr 6, 2023
|
@stevhliu I applied your suggestions, thanks again! Would you mind taking another look? |
stevhliu
approved these changes
Apr 10, 2023
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
pcuenca
commented
Apr 10, 2023
|
Thanks a lot @stevhliu, it's much better now! 🙌 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
w4ffl35
pushed a commit
to w4ffl35/diffusers
that referenced
this pull request
Apr 14, 2023
* Initial draft of Core ML docs. * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Fix Core ML spelling * Apply the rest of suggestions. * Attempt to fix hyperlink inside Tip. * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
dg845
pushed a commit
to dg845/diffusers
that referenced
this pull request
May 6, 2023
* Initial draft of Core ML docs. * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Fix Core ML spelling * Apply the rest of suggestions. * Attempt to fix hyperlink inside Tip. * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Initial draft of Core ML docs. * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Fix Core ML spelling * Apply the rest of suggestions. * Attempt to fix hyperlink inside Tip. * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially opened as #2489. Very much interested in getting feedback from @yiyixuxu, @stevhliu; I adapted the text from the blog post and added some recent stuff, but not fully happy about the flow yet.