Cache repeated parameter datatype queries for the same model #4976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4975. Adds a generic LRU cache for the expensive parameter datatype computation function with an optional fallback to the uncached implemnetation in cases where the underlying module is not hashable (since this can be any torch module subclass, it's possible that it might have overriden the
__hash__
or added properties which make it unsafe to hash). From my local testing, the perf increase is very noticable (2X to 3X) more benchmarks are below.Benchmarks
For the following script which loads the LoRA state dict into memory and then runs
load_lora_weights
/unload_lora_weights
cycle 5 times, the results are as following:Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.