Fast LoRA initialization by skipping redundant linearizations #4980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #4975, along with #4976 and #4979. This PR leverages the accelerate's init empty weights (just like diffusers automatically does on certain models, like vae for SD) when we are initializing the LoRA weights for the first them. This grants a great boost for avoiding unnecessary computations which would be overriden just a moment later. On top of #4976 and #4979, this PR makes the
load_lora_weights()
+unload_lora_weights()
cycle take around a second (1.05seconds
to be precise) from ~6 seconds without any of them. Relative effect on top of the first two PRs (combined) is about 1.33x.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.