Skip to content

Conversation

isidentical
Copy link
Contributor

What does this PR do?

Part of #4975, along with #4976. This PR avoids redundant deep copy operations when we are loading a LoRA. The average gain (with a LoRA where network alphas are present) on top of #4976 is about 1.35x (brings down the timings from 1.9 seconds to 1.4 seconds). On top of main it is less significant but still a good win.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@isidentical isidentical marked this pull request as ready for review September 11, 2023 17:05
@patrickvonplaten
Copy link
Contributor

I think this is also already fixed in: #4994 (very sorry about not seeing this PR earlier 🙏)

@patrickvonplaten
Copy link
Contributor

Closing as already part of main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants