Use SSE for Invoke, JSON for view_parameters #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously added dynamic_space to isGradioTool(), but this was too broad. The dynamic_space tool has two operations: - view_parameters: can use direct_response=true (no streaming needed) - invoke: needs direct_response=false (requires streaming/progress) Solution: - Keep isGradioTool() focused on gr<number>_/grp<number>_ pattern tools - Enhanced isGradioToolCall() to check dynamic_space arguments - Only sets direct_response=false when operation="invoke" This allows view_parameters to remain fast with direct JSON responses while invoke gets proper streaming support.
evalstate
changed the title
evalstate
deleted the
claude/fix-dynamic-space-invoke-streaming-011CV2CCtztFce9Bxajivb3w
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up SSE behaviour