Fix broken gradio_files tool listing #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gradio_files tool was broken because it was being excluded from Gradio setup after commit 6842a47 removed it from isGradioTool(). Root cause: - isGradioTool('gradio_files') now returns false (for streaming logic) - skipGradioSetup() was skipping ALL non-Gradio tools - This caused the proxy factory to return early (mcp-proxy.ts:124-126) - gradio_files was never registered (happens at mcp-proxy.ts:215-249) Solution: Add special case for gradio_files in skipGradioSetup() to ensure it still gets registered during the Gradio setup phase, even though it doesn't need special streaming handling. This separates two concerns: 1. Streaming behavior (isGradioTool) - gradio_files doesn't need this 2. Registration phase (skipGradioSetup) - gradio_files DOES need this
evalstate
deleted the
claude/fix-gradio-files-tool-011CV63WmJ12KLqsHwnRSGXU
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradio_files tool was broken because it was being excluded from Gradio setup after commit 6842a47 removed it from isGradioTool().
Root cause:
Solution:
Add special case for gradio_files in skipGradioSetup() to ensure it still gets registered during the Gradio setup phase, even though it doesn't need special streaming handling.
This separates two concerns: