Add notice for "createdAt" key in API #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Kakulukian
changed the title
julien-c
reviewed
Nov 9, 2023
julien-c
requested changes
Nov 9, 2023
docs/hub/api.md
Outdated
|
|
||
| This is equivalent to `huggingface_hub.list_models()`. | ||
|
|
||
| The key `createdAt` in the response begins on `2022-03-02T23:29:04.000Z` as a result of a special migration. |
Member
There was a problem hiding this comment.
IMO this should be mentioned just once, under a # Repo creation times heading, with a wording like:
For all repos-returning API calls, the
createdAtattribute is the time when the repo was created.
Note that there is a special value of2022-03-02T23:29:04.000Zfor all repos that were created before we started storing the creation date.
cc'ing @Wauplin too
julien-c
approved these changes
Nov 9, 2023
Wauplin
approved these changes
Nov 9, 2023
Contributor
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
Looks good! Will integrate it to huggingface_hub as well 🔥
Member
|
looks fine in prod IMO, thanks: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/huggingface/moon-landing/pull/7991 (private)