Fix /api/repos/move documentation in api.md
#1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to huggingface/huggingface_hub#1813. In `/api/repos/move`, we (I? 😄) forgot to mention the `type` parameter to specify the repo type. cc @enzostvs you would have to update the API Playground as well to add this parameter. Thanks in advance!
|
The documentation is not available anymore as the PR was closed or merged. |
stevhliu
reviewed
Nov 13, 2023
docs/hub/api.md
Outdated
| "fromRepo" : "namespace/repo_name", | ||
| "toRepo" : "namespace2/repo_name2" | ||
| "toRepo" : "namespace2/repo_name2", | ||
| "type": "dataset", |
Member
There was a problem hiding this comment.
In the other examples, "type":"type" instead of a specific type like dataset. I wonder if it might be better to just leave it as type to signal that it can also be a model or space?
Suggested change
| "type": "dataset", | |
| "type": "type", |
Contributor
Author
There was a problem hiding this comment.
Good catch. I've pushed a new commit (8ee8745) to align how we are setting this. I prefer to have "type": "model" as an example and explain in words what are the possible values.
Contributor
Author
|
Great, thanks for reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to huggingface/huggingface_hub#1813.
In
/api/repos/move, we (I? 😄) forgot to mention thetypeparameter to specify the repo type.cc @enzostvs you would have to update the API Playground as well to add this parameter. Thanks in advance!
EDIT: see PR documentation here