Add docs on download stats #1108
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
Will be useful for queries like this: https://huggingface.co/migtissera/HelixNet/discussions/9 |
davanstrien
left a comment
davanstrien
left a comment
There was a problem hiding this comment.
A few small suggestions (feel free to ignore!)
|
(can we wait Monday before merging even if already approved? Just want to read it without rushing and won't have time today :) ) |
Co-authored-by: Daniel van Strien <davanstrien@users.noreply.github.com> Co-authored-by: Julien Chaumond <julien@huggingface.co>
|
yes for sure let's wait a few days – also interested in @LysandreJik's read |
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Looks good to me in principle, but I'd add one or two lines to specify explicitly that we're not doing anything funky on the user's side. We're absolutely optimizing for minimal number of requests and we're not sending any information. Everything happens server-side.
|
Thanks everyone for the reviews. I'll merge this later today if nobody else adds comments |
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Looks great!
A small clarification regarding model downloads would be to define a "download" as every use of the target file, including when it's already cached in the user's computer. Probably not necessary.
|
For now let's go with this and later we can iterate |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Fix #100