-
Notifications
You must be signed in to change notification settings - Fork 380
Fix links #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like you've updated documentation related to model or dataset cards in this PR. Some content is duplicated among the following files. Please make sure that everything stays consistent.
|
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
julien-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's wait for @mishig25 review though because i think those links used to work
|
The detail:
|
mishig25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@severo thanks a lot for finding this problem.
Explanation why this problem is occurring.
- We've used relative links such as
[🤗 Datasets](../datasets/index)to switch from hub-docs page to another library's page. - This relative path works fine when there is no
{lang}or{branch}path present in the URL.
Example:
[🤗 Datasets](../datasets/index) was going to different paths depending whether {lang} was present or not:
- /docs/hub/datasets-dask -> /docs/datasets/index (good)
- /docs/hub/en/datasets-dask -> /docs/hub/datasets/index (bad)
To clarify, using relative links is not a problem when you are linking pages within a same library (since they will share same {lang} or {branch} prefixes). Using relative links is a problem when linking pages from different libraries. Therefore, we should always use absolute path /docs/{lib}/{page} when linking pages from different libraries.
Co-authored-by: Mishig <dmishig@gmail.com>
|
Done. I changed |
|
Thanks for the clarification @mishig25! |
Found with