-
Notifications
You must be signed in to change notification settings - Fork 386
Update Space to dataset storage docs #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
osanseviero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure about this change. The schedule commit setup is nice but a bit complex to set up compared to just repository. Should we add a simple commit example to the guide?
Maybe it is the docs/Space that are not simple enough which makes it looks as a complicated setup. Because IMO it really isn't that complex to use Basically, the setup goes from repo = Repository(
local_dir="data/", clone_from=DATASET_REPO_URL, use_auth_token=HF_TOKEN
)
repo.push_to_hub() # on every callto scheduler = CommitScheduler(
repo_id=DATASET_ID, repo_type="dataset", folder_path="data/", token=HF_TOKEN
) |
|
Feel free to resolve the conflict and merge, thanks a lot! |
|
Lol, thanks for reviving this PR @coyotte508! |
|
Conflict resolved, I'm merging. Thanks for the reminder! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
This PR updates the "Data Persistence for Spaces" section (here and here) to showcase
CommitSchedulerinstead ofRepositorywith this example Space and this guide.