Add google extra with google-cloud-storage
#77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Align indent size with `apt-get install` even if those are just args - Align flag usage notation from `-U` to `--upgrade` i.e. using full name instead of shortened one for readability - Install `google-cloud-storage` from `google` extra instead (`google` extra was included recently as otherwise the installations from the wheel not relying on this Dockerfile would fail with an ImportError on `google-cloud-storage` when either deploying from Vertex AI or setting the `AIP_STORAGE_URI` env var)
Ideally the `pip install` command shouldn't be required as it's installed already within the `integration-test-pytorch:gpu` image, but if adding it, to ensure consistency we should also include the recently included `google` extra that comes with `google-cloud-storage`; otherwise the tests within #76 will fail
philschmid
approved these changes
Aug 5, 2024
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
googleextra withgoogle-cloud-storage, as the dependency appears missing with anImportErrorwhen installing directly from the wheel, instead of relying on theDockerfilebuilt and pushed, as there it's indeed installed directly aspip install google-cloud-storage.So on, as to ensure consistency as in
inf2for AWS Inferentia 2, thegoogleextra has been included to install from the extra instead of directly installing the dependency, helpful also if in the future we decide to pin the dependency, add more dependencies forgoogle, and so on.This PR also briefly revisits the formatting and style of
dockerfiles/pytorch/Dockerfile,setup.pyandsetup.cfg; as well as including missing metadata withinsetup.py.