Release 0.4.3 version with sentence-transformers fixes
#81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oOraph
approved these changes
Aug 12, 2024
`peft` requires `torch` as a mandatory dependency, so adding `peft` as a core dependency means that `torch` will be installed i.e. even when `pip install -e ".[quality]"` which slows things a bit, since `torch` installation takes time; and in some cases is not needed, so moving `peft` into the `torch` extra makes the most sense for the moment (not final).
alvarobartt
changed the title
0.4.3dev0 version for upcoming release0.4.3dev0 version and fix broken tests
alvarobartt
changed the title
0.4.3dev0 version and fix broken tests0.4.3 version with sentence-transformers fixes
oOraph
approved these changes
Aug 13, 2024
oOraph
reviewed
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
versionidentifier within thesetup.pyto0.4.3to be immediately released, as due to the addition of theHF_TRUST_REMOTE_CODEenvironment variable, thesentence-transformersintegration was broken as thekwargshandling was not done as expected.Additionally, within this PR also the unit tests for the Google Cloud Storage (GCS) functions are solved since now the anonymous client is used instead. Also this PR temporarily does move the
peftdependency into thetorchextra instead of as a core dependency, as otherwisetorchwas being installed as it's a dependency ofpeftwhich was leading to slow installation times when running e.g.pip install -e ".[quality]".