Skip to content

Ci move #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Ci move #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2aea5fd
change default runner
glegendre01 Sep 26, 2024
6764955
remove run on param
glegendre01 Sep 26, 2024
799a599
add cache
glegendre01 Sep 26, 2024
dd7e01d
change unit test runner
glegendre01 Sep 26, 2024
507831e
fix hf cache permissions
glegendre01 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/integration-test-action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,12 @@ on:
runs_on:
type: string
required: false
default: '["single-gpu", "nvidia-gpu", "t4", "ci"]'
default: 'aws-g4dn-2xlarge-cache'

jobs:
pytorch-integration-tests:
runs-on: ${{ fromJson(inputs.runs_on) }}
runs-on:
group: ${{ inputs.runs_on }}
env:
AWS_REGION: ${{ inputs.region }}
HF_HOME: ${{ inputs.hf_home }}
Expand All @@ -66,4 +67,4 @@ jobs:
python -m pytest \
${{ inputs.test_path }} -n ${{ inputs.test_parallelism }} \
--log-cli-level='${{ inputs.log_level }}' \
--log-format='${{ inputs.log_format }}'
--log-format='${{ inputs.log_format }}'
2 changes: 0 additions & 2 deletions .github/workflows/integration-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,10 @@ jobs:
with:
test_path: "tests/integ/test_pytorch_remote_cpu.py"
build_img_cmd: "make inference-pytorch-cpu"
runs_on: "['ci']"
pytorch-integration-local-cpu:
name: Local Integration Tests - CPU
uses: ./.github/workflows/integration-test-action.yaml
with:
test_path: "tests/integ/test_pytorch_local_cpu.py"
build_img_cmd: "make inference-pytorch-cpu"
test_parallelism: "1"
runs_on: "['ci']"
8 changes: 5 additions & 3 deletions .github/workflows/unit-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ concurrency:

jobs:
pytorch-unit-test:
runs-on: [single-gpu, nvidia-gpu, t4, ci]
runs-on:
group: aws-g4dn-2xlarge-cache
env:
AWS_REGION: us-east-1
CACHE_TEST_DIR: /mnt/hf_cache/hf-inference-toolkit-tests
Expand All @@ -28,8 +29,9 @@ jobs:
- uses: actions/checkout@v4.1.1
- name: Copy unit tests to cache mount
run: |
rm -rf ${{ env.CACHE_TEST_DIR }} && \
mkdir ${{ env.CACHE_TEST_DIR }} && \
sudo rm -rf ${{ env.CACHE_TEST_DIR }} && \
sudo mkdir ${{ env.CACHE_TEST_DIR }} && \
sudo chown -R runner ${{ env.CACHE_TEST_DIR }}
cp -r tests ${{ env.CACHE_TEST_DIR }}
- name: Docker Setup Buildx
uses: docker/setup-buildx-action@v3.0.0
Expand Down