Fix Dockerfile and some minor updates
#97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Vertex-related stuff since there's already a dedicated repository for building, pushing and testing the Vertex AI compatible images i.e. https://github.com/huggingface/Google-Cloud-Containers - Add missing PHONY targets - Add some in-line comments on each target
- Python 3.11 was being installed, but Python 3.10 was used instead; both via `python` and when installing with `pip` - Fix `pip` installation to use recommended installation path as per https://pip.pypa.io/en/stable/installation/ - Remove `vertex` build stage since there's already a dedicated repository for the Google Cloud Containers, including the Vertex AI compatible ones, i.e. https://github.com/huggingface/Google-Cloud-Containers
alvarobartt
force-pushed
the
fix-dockerfiles
branch
from
f02f8b1 to
cd33113
Compare
philschmid
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly fixes the
Dockerfileas there was an issue with the Python 3.11 installation, as it was being installed but the default Python 3.10 was being used instead.Besides those fixes, additionally some other minor formatting / updates have been applied, such as:
makefilerename and update toMakefilevertexrelated targets fromMakefileandDockerfileMakefileand updatePHONYlist of available targets.dockerignoreto ignore.gittoosetup.py,pyproject.toml,entrypoint.sh, andMANIFEST.infor a consistent use of spacing