Skip to content

Conversation

@mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Nov 18, 2024

export type InferenceSnippet from @hfjs/tasks

@mishig25 mishig25 marked this pull request as ready for review November 18, 2024 10:00
@mishig25 mishig25 merged commit b340e69 into main Nov 18, 2024
5 checks passed
@mishig25 mishig25 deleted the export_inference_type branch November 18, 2024 10:02
@coyotte508
Copy link
Member

As explained in #1035 (comment), they're already exported, there was no need for this PR

@mishig25
Copy link
Collaborator Author

mishig25 commented Nov 18, 2024

I created this PR because I wanted to do:

import type { InferenceSnippet } from "@huggingface/tasks";

Is it correct to assume that: without this PR, I could NOT do

import type { InferenceSnippet } from "@huggingface/tasks";

and instead I can do

import { snippets } from "@huggingface/tasks";
// and use as snippets.InferenceSnippet

?

@coyotte508
Copy link
Member

yes, you would need to import snippets directly (before this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants