🧑💻 Update Apple Silicon hardware, add M4 series #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: - M2 Pro ~6.8 (FP32, 19 cores) - M3 4.1 (FP32, 10 cores) - M3 Pro 6.39-7.4 (FP32, 18 cores) New: - M4 4.6 (FP32, 10 cores) - M4 Pro 9.2 (FP32, 20 cores) - M4 Max 18.4 (FP32, 40 cores)
starkdmi
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
pcuenca
reviewed
Nov 19, 2024
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Looks good to me! Where did you get the data?
| }, | ||
| "Apple M2 Pro": { | ||
| tflops: 13.6, | ||
| tflops: 6.8, |
Contributor
Author
There was a problem hiding this comment.
It's more than M2 Max (13.49), probably FP16? But most of Apple Silicon benchmarks here are FP32 as those are sometimes reported by Apple and more probably are correct.
Contributor
Author
A few benchmarks websites plus Apple references. |
pcuenca
approved these changes
Nov 19, 2024
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Ok for me to make Apple Silicon numbers consistent and use FP32 if those figures come from ~official sources. Let's wait for another review to merge :)
julien-c
approved these changes
Nov 20, 2024
Member
julien-c
left a comment
julien-c
left a comment
There was a problem hiding this comment.
looks awesome! Coincidentally, I just received my M4 Max MBP so this is perfect timing:)
Member
|
thx a ton for the contrib! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
New: