Skip to content

Conversation

@gokayfem
Copy link
Contributor

Adds fal.ai inference endpoints

@SBrandeis
Copy link
Contributor

Cool stuff @gokayfem !

Would you mind adding tests for these new models? I think one per modality/task would be nice to ensure the inference client is compatible with FAL's APIs.

Tests are defined in HfInference.spec.ts.

To run them, you'll need to add a HF_FAL_AI_KEY to your environment and use the pnpmcommand:

export HF_FAL_AI_KEY="valid-fal-ai-key"
pnpm run test -t 'Fal AI'

@julien-c
Copy link
Member

Hey @gokayfem in #1109 @SBrandeis has switched to a dict of mappings, indexed by the HF model's task type (which in turn, conditions the API schema we expect)

Can you rebase your PR on top of main? Also happy to jump on a quick call if it's easier!

@aykutkardas
Copy link
Contributor

aykutkardas commented Jan 20, 2025

Hey @gokayfem in #1109 @SBrandeis has switched to a dict of mappings, indexed by the HF model's task type (which in turn, conditions the API schema we expect)

Can you rebase your PR on top of main? Also happy to jump on a quick call if it's easier!

Hey @julien-c 🤗 I updated the PR. ✅

Copy link
Contributor

@SBrandeis SBrandeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SBrandeis SBrandeis merged commit 1a07402 into huggingface:main Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants