Do not require all dummy api keys in inference tests #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
SBrandeis,
coyotte508,
hanouticelina and
julien-c
as code owners
coyotte508
approved these changes
Mar 3, 2025
| describe.concurrent( | ||
| "Fal AI", | ||
| () => { | ||
| const client = new HfInference(env.HF_FAL_KEY); |
Member
There was a problem hiding this comment.
use ?? instead of || (same for others)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently find it annoying when I want to run tests locally (that already have cached tapes) to set the env variables to
"dummy":This PR is a suggestion to get rid of that and default to
"dummy"in the code instead of in the CI workflow file. Happy to get better suggestions if you think of one (in Python I would do an automatic fixture "get_api_key_or_dummy" but quite specific to pytest).As a bonus, no need to update
.github/workflows/test.ymlwhen adding a new provider.WDYT?