-
Notifications
You must be signed in to change notification settings - Fork 538
Add text to video snippets #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kefranabg , could you add a test case to https://github.com/huggingface/huggingface.js/blob/main/packages/tasks-gen/scripts/generate-snippets-fixtures.ts please?
{
testName: "text-to-video",
model: {
id: "tencent/HunyuanVideo",
pipeline_tag: "text-to-video",
tags: [],
inference: "",
},
providers: ["fal-ai"],
languages: ["js", "py"],
},You then need to run pnpm i && pnpm generate-snippets-fixtures inside ./packages/tasks-gen. This should generate some snippet examples that you can commit in your PR. Makes reviewing much easier + it adds a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
@SBrandeis @Wauplin I'm not sure I prefer to ask: is there any other that I could be missing here? like curl or with other client libraries? |
I think for now it's fine keeping it like this. It could be possible to add a plain |
There is probably some missing snippets, I added these based on our docs. Feel free to update if something's missing
Needed for https://github.com/huggingface-internal/moon-landing/pull/12722