[Inference] top-down injection of providerHelper #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanouticelina
approved these changes
Apr 11, 2025
Contributor
hanouticelina
left a comment
hanouticelina
left a comment
There was a problem hiding this comment.
thank you for fixing this! it's indeed much safer to control where the getProviderHelper function is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hanouticelina @Wauplin
Prompted by: https://huggingface.slack.com/archives/C02EMARJ65P/p1744370608755449 (internal)
This PR reduces the number of places where we call
getProviderHelperby enforcing it's passed as an argument by the caller when neededBecause
getProviderHelperis fallible, calling it from different places (sometimes deep in the function call chain) can be dangerous and result in unexpected bugs.This PR reduces this risk by reducing the number of different places where we call
getProviderHelper, and instead pass it as an argument top-downIt also has the benefits of clearly indicating which functions depend on provider-specific logic