[Inference] fix feature extraction (embeddings) for sambanova #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngface.js into fix-feature-extraction
Wauplin
approved these changes
Apr 22, 2025
Contributor
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
👍
Re: OpenAI-compatible API, agree with it yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the widget of https://huggingface.co/intfloat/e5-mistral-7b-instruct
i didn’t want to introduce a breaking change in this PR, but we should consider adding support for the OpenAI Embeddings API. Other providers like Fireworks AI and Together also host embedding models with OpenAI-compatible endpoints. AFAIK, TEI supports the OAI Embeddings API as well.