add phantom to libraries #1411
add phantom to libraries #1411
Conversation
merveenoyan
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Thank you! If possible, a code snippet would be 🔥
|
@pcuenca just added, thanks for review ❤️ |
| snippets: snippets.perception_encoder, | ||
| countDownloads: `path_extension:"pt"`, | ||
| }, | ||
| phantom: { |
There was a problem hiding this comment.
Unfortunately phantom is already used by some repos (https://huggingface.co/models?other=phantom) depending on https://github.com/ByungKwanLee/Phantom which is a totally different project.
Would it be possible to define it as phantom-video for instance? In any case, it will require to update the model card metadata in https://huggingface.co/bytedance-research/Phantom before getting this PR merged (with library_name: phantom-video)
There was a problem hiding this comment.
or phantom-wan to match the library name in Python?
Co-authored-by: Lucain <lucain@huggingface.co>
Co-authored-by: Lucain <lucain@huggingface.co>
|
@Wauplin I addressed your comments, thanks a lot! |
There was a problem hiding this comment.
All good! Thanks for the changes :)
@merveenoyan can you update https://huggingface.co/bytedance-research/Phantom/discussions/2 to set phantom-wan as library name and the nmake sure it gets merged? Once merged (let me know when it's the case), we will merge and release this one.
|
yes sorry I was applying some formats and noticed you did too! 🤠 I reached out privately |
|
ouf I have merged this. is it ok or do I revert? |
No worries, ok to keep it like this! Just make sure that they do set |
No description provided.