Skip to content

Explicit check for existence of chat_template #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 9, 2025
Merged

Explicit check for existence of chat_template #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
abfc295
Explicit check for existence of chat_template
pcuenca Sep 3, 2025
94e7d48
Improve chat template existence check.
pcuenca Sep 8, 2025
7aa1329
Rename
pcuenca Sep 8, 2025
962a309
Merge remote-tracking branch 'origin/main' into conversational-chat-t…
pcuenca Sep 8, 2025
a210a39
Apply suggestions from code review
pcuenca Sep 8, 2025
0bb7cd9
Update packages/tasks/src/model-data.ts
pcuenca Sep 8, 2025
2750826
Update packages/tasks/src/tokenizer-data.ts
pcuenca Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/tasks/src/model-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ export interface ModelData {
quant_method?: string;
};
tokenizer_config?: TokenizerConfig;
processor_config?: {
chat_template?: string;
};
chat_template_jinja?: string;
adapter_transformers?: {
model_name?: string;
model_class?: string;
Expand Down
7 changes: 6 additions & 1 deletion packages/tasks/src/model-libraries-snippets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,6 +1476,11 @@ export const terratorch = (model: ModelData): string[] => [
model = BACKBONE_REGISTRY.build("${model.id}")`,
];

const hasChatTemplate = (model: ModelData): boolean =>
model.config?.tokenizer_config?.chat_template !== undefined ||
model.config?.processor_config?.chat_template !== undefined ||
model.config?.chat_template_jinja !== undefined;

export const transformers = (model: ModelData): string[] => {
const info = model.transformersInfo;
if (!info) {
Expand All @@ -1498,7 +1503,7 @@ export const transformers = (model: ModelData): string[] => {
`${processorVarName} = ${info.processor}.from_pretrained("${model.id}"` + remote_code_snippet + ")",
`model = ${info.auto_model}.from_pretrained("${model.id}"` + remote_code_snippet + ")"
);
if (model.tags.includes("conversational")) {
if (model.tags.includes("conversational") && hasChatTemplate(model)) {
if (model.tags.includes("image-text-to-text")) {
autoSnippet.push(
"messages = [",
Expand Down
Loading