Skip to content

Do not send duplicate files in shards #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

Do not send duplicate files in shards #1840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/hub/src/utils/createXorbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ export async function* createXorbs(
void,
undefined
> {
const alreadyDoneFileSha256s: Set<string> = new Set();
const chunkModule = await import("../vendor/xet-chunk/chunker_wasm");
let xorbId = 0;

Expand Down Expand Up @@ -147,6 +148,11 @@ export async function* createXorbs(
const remoteXorbHashes: string[] = [""]; // starts at index 1 (to simplify implem a bit)

for await (const fileSource of fileSources) {
if (alreadyDoneFileSha256s.has(fileSource.sha256)) {
continue;
}
alreadyDoneFileSha256s.add(fileSource.sha256);

const chunker = new chunkModule.Chunker(TARGET_CHUNK_SIZE);
try {
xorb.fileSize[fileSource.path] = fileSource.content.size;
Expand Down
Loading