-
Notifications
You must be signed in to change notification settings - Fork 544
Add image-matching-models to model libraries #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (with minor comment).
Orthogonal topic but note that I have opened https://huggingface.co/image-matching-models/eloftr/discussions/1 to remove the duplicated file called eloftr_outdoors.safetensors (with a blank space at the end).
pcuenca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Agree with @Wauplin's suggestions.
Co-authored-by: Lucain <lucainp@gmail.com>
|
|
|
@ariG23498 @pcuenca For the record for next time, the Hub backend has the concepts of "main library" and "other libraries". The main library is the one used to count downloads on the repo. The "main libraries" + the "other libraries" are used to display code snippets on a model page. A good example to illustrate this is the sentence-transformers models. Most of them are both tagged as
So all of this to say, a model can be linked to several libraries but only 1 of them is the "main one". In practice, the Hub backend will first check the Getting back to the original question:
Since it has a single library, no matter if you set it in the model cards' Hope this makes it all clear! Let's merge the PR now, it should be live on the Hub within a few days ;) |
|
Thanks a lot for taking the time to explain everything so clearly @Wauplin! 🙌 My shortcut way of thinking was to use This is great information to share with these authors and other prospective collabs. |
Then this is an even better reason to use the Glad explanations helped! 🤗 |

CC: @pcuenca (from our conversation about image matching models repository)
For others:
image-matching-modelsand that would count thesafetensorsdownload