lmstudio deeplink for MLX models #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagil
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
osanseviero and
pcuenca
as code owners
julien-c
reviewed
Oct 9, 2024
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Vaibhavs10
reviewed
Oct 10, 2024
Contributor
Vaibhavs10
left a comment
Vaibhavs10
left a comment
There was a problem hiding this comment.
Niceee! Looking forward to testing this 😄
julien-c
approved these changes
Oct 10, 2024
| } | ||
|
|
||
| function isMlxModel(model: ModelData) { | ||
| return model.tags.includes("mlx"); |
Member
There was a problem hiding this comment.
Suggested change
| return model.tags.includes("mlx"); | |
| return model.library_name === "mlx"; |
or maybe like this @Vaibhavs10 if we want to be pedantic about it
Member
There was a problem hiding this comment.
actually nvm because https://huggingface.co/mlx-community/Llama-3.2-3B-Instruct-4bit for instance is not library=mlx
Contributor
There was a problem hiding this comment.
Yes! Just mlx tag would be more reliable 👍
Member
|
CI failure is unrelated |
Vaibhavs10
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Not yet tested)
LM Studio 0.3.4 and newer supports MLX - reference