Update hardware.ts #974
Merged
Update hardware.ts #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more GPUs to the list, all fp16 performance.
walmartbaggg
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
osanseviero and
pcuenca
as code owners
pcuenca
reviewed
Oct 20, 2024
packages/tasks/src/hardware.ts
Outdated
Comment on lines
88
to
89
| tflops: 17.972, // source: https://www.techpowerup.com/gpu-specs/a16-pcie.c3794 | ||
| memory: [64], // this one you do not have to add, as its 4x. |
Member
There was a problem hiding this comment.
Yeah, it's a bit confusing as this is a bundle of 4 GPUs in a single card. I'm not sure if we should report the per-GPU specs instead, as the use cases of 4x16 GB are different to 1x64 GB cards.
Contributor
Author
There was a problem hiding this comment.
Alright I will just remove it since it will be inaccurate anyways, since its basically 1 gpu, but 4 parts? I am always confused on those.
Member
There was a problem hiding this comment.
Yes, another idea would be to use the per-unit specs: 4.49 tflops and 16 GB of RAM, but that could be somewhat confusing as well.
Member
|
I see the CI failing in other PRs as well, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more GPUs to the list, all fp16 performance.