Lint fixes #990
Merged
Lint fixes #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcuenca
requested review from
SBrandeis,
Wauplin,
gary149 and
julien-c
as code owners
Member
Author
|
Failing in some PRs such as #986 |
coyotte508
approved these changes
Oct 28, 2024
julien-c
approved these changes
Oct 29, 2024
Vaibhavs10
approved these changes
Oct 29, 2024
Vaibhavs10
reviewed
Oct 29, 2024
Contributor
Vaibhavs10
left a comment
Vaibhavs10
left a comment
There was a problem hiding this comment.
I wonder if we should just add a pre-commit in the repo to fix all Lint woes.
(orthogonal to the PR ofc)
Member
Author
There's already a lint check, I think we should not merge if it complains (unless in exceptional cases). |
coyotte508
pushed a commit
that referenced
this pull request
Oct 29, 2024
This PR fixes the failing CI: - ~some formatting issues in `packages/tasks`~ already done in #990 - in `listFiles`, `entry.security` has been replaced by `entry.securityFileStatus` server-side. This PR updates the data structure + test to address this change. Expectation: green CI 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.