Copy over Torch from hf-nix and fix the AArch64 build #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have decided to make kernel-builder standalone to make it easier to maintain Torch versions as part of the same repo. This copies over Torch from hf-nix. Other bits are still needed, but let's start somewhere.
Torch vendors libgfortran, which has zlib as a dependency. We might want to use system libgfortran in the future instead, but it requires more investigation/testing. Fixes #301.
danieldk
commented
Nov 19, 2025
Comment on lines
+198
to
+199
| # Torch on aarch64-linux vendors libgfortran, which requires zlib. | ||
| ++ lib.optionals (stdenv.hostPlatform.isLinux && stdenv.hostPlatform.isAarch64) [ zlib ]; |
Member
Author
There was a problem hiding this comment.
For reviewing, these are the only changed lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have decided to make kernel-builder standalone to make it easier to maintain Torch versions as part of the same repo. This copies over Torch from hf-nix. Other bits are still needed, but this was needed to fix #301 within the repo.
Torch vendors libgfortran, which has zlib as a dependency. We might want to use system libgfortran in the future instead, but it requires more investigation/testing.