Improve errors for layer validation #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the repo and layer name as well as the name of the class that is being compared to (when applicable).
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
danieldk
force-pushed
the
better-validation-errors
branch
from
6412a4e to
56da74e
Compare
sayakpaul
approved these changes
Sep 16, 2025
| if len(params) != len(ref_params): | ||
| raise TypeError( | ||
| "Forward signature does not match: different number of arguments." | ||
| f"Forward signature of {repo} does not match `{check_cls.__name__}`: different number of arguments." |
There was a problem hiding this comment.
Superb! This should be more than enough!
| reason="There is something weird when writing to the Hub from a GitHub CI.", | ||
| strict=True, | ||
| ) | ||
| @pytest.mark.token |
There was a problem hiding this comment.
Maybe use skip as discussed? 👀
There was a problem hiding this comment.
I thought it was nicer if it's possible to run the test locally with --token,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the repo and layer name as well as the name of the class that is being compared to (when applicable).
Fixes #143.