Add the kernels check subcommand
#158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This subcommand checks a given kernel. Currently it applies the same ABI checks as `kernel-abi-check` in `kernel-builder`.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
MekkCyber
previously approved these changes
Sep 25, 2025
Comment on lines
+11
to
+27
| src = fetchPypi { | ||
| inherit version; | ||
| pname = "kernel_abi_check"; | ||
| hash = "sha256-goWC7SK79FVNEvkp3bISBwbOqdSrmobANtrWIve9/Ys="; | ||
| }; | ||
|
|
||
| cargoDeps = rustPlatform.fetchCargoVendor { | ||
| inherit pname version src sourceRoot; | ||
| hash = "sha256-+1jdbKsDKmG+bf0NEVYMv8t7Meuge1z2cgYfbdB9q8A="; | ||
| }; | ||
|
|
||
| sourceRoot = "kernel_abi_check-${version}/bindings/python"; | ||
|
|
||
| pyproject = true; | ||
|
|
||
| nativeBuildInputs = with rustPlatform; [ cargoSetupHook maturinBuildHook ]; | ||
| } |
There was a problem hiding this comment.
Does this mean we can't install kernels without installing kernel-abi-check ?
There was a problem hiding this comment.
It's an optional dependency in pyproject.toml. The Nix is for the project's devshell, where we always want to have the package available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This subcommand checks a given kernel. Currently it applies the same ABI checks as
kernel-abi-checkinkernel-builder.