feat: allow kernels to be uploaded to a revision #161
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The failing tests seem to be unrelated? |
| @@ -1,18 +1,19 @@ | |||
| from pathlib import Path | |||
| import sys | |||
| from pathlib import Path | |||
|
@danieldk good for you? |
| upload_parser.add_argument( | ||
| "--revision", | ||
| type=None, | ||
| help="If set, the upload will be made to a particular branch of the provided `repo_id`.", | ||
| ) |
There was a problem hiding this comment.
I wonder if we should be more explicit and call this branch. I find revision a bit confusing, since people use it to refer to commit SHAs, tags, etc. as well.
It's also not super-clear from the huggingface_hub docs what this means in upload_folder:
The git revision to commit from. Defaults to the head of the "main" branch.
What happens if I'd put an actual git SHA here?
There was a problem hiding this comment.
Indeed. I changed it to branch. Maybe that's a better cognitive distinction but in theory, we can still pass all the acceptable revision variants (SHA, tag, etc.), though. But I don't see any clean way to differentiate amongst them, either.
There was a problem hiding this comment.
No me neither, but at least it's clear what should be passed.
4 participants
No description provided.