feat: allow get_kernel to log telemetry. #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
danieldk
reviewed
Oct 14, 2025
Comment on lines
+533
to
+536
| "kernels": __version__, | ||
| "torch": torch.__version__, | ||
| "build_variant": build_variant(), | ||
| "file_type": "kernel", |
There was a problem hiding this comment.
Looks non-revealing 👍, though I would be in favor of mentioning in the docs that we are collecting this information + how to switch it off.
There was a problem hiding this comment.
Sure! Which part of the docs should we put this in?
There was a problem hiding this comment.
Not sure. Maybe an item here https://huggingface.co/docs/kernels/faq with an additional question like How can I disable kernel reporting in the user-agent?
Co-authored-by: Daniël de Kok <me@danieldk.eu>
danieldk
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values in
user_agentare pretty non-identifiable. But LMK if you think otherwise.I have also made it so that the logging is configurable through an env var.