bump datasets to 4.0.0 #1990
Merged
bump datasets to 4.0.0 #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Upgrade the Hugging Face datasets dependency to a new major version.
- Update dependency constraint for datasets to 4.0.0
- Remove the old TODO comment
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
michel-aractingi
added
dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Bump hf datasets version to 4.0.0 at minimum.
HF Datasets v4 introduces some nice features for streaming and some breaking changes with respect to previous changes.
LeRobotDatasets v2.1 was not made compatible with the with the v4 release and we chose to cap the dependency. However, the recent merge of #1412, LeRobotDataset v3 is compatible with the recent versions of hf datasets thus allowing us to bump the version. Now, we can be more up to date with the latest hf datasets features without having to modify any logic in our code.
Tests
Checked that the tests for datasets pass for all v4+ releases (4.0.0, 4.1.0, 4.1.1)