Fix: correct argument order in MajAtN.compute #1058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
lighteval/src/lighteval/metrics/metrics_sample.pyline 1258, theMajAtN.computemethod calls:However,
compute_score(e.g.,MultilingualExtractiveMatchMetric.compute) expects the signature:As a result, the arguments are swapped, which cause runtime errors.
To Reproduce
Steps to reproduce the behavior:
lightevalversion 0.12.2.MajAtNwith a subclass ofMultilingualExtractiveMatchMetric.computeon a sampleDocandModelResponse.TypeErroror incorrect metric values due to the argument order mismatch.Expected Behavior
MajAtN.computeshould pass arguments in the correct order:so that
compute_score(doc, model_response)executes correctly.