-
Notifications
You must be signed in to change notification settings - Fork 475
Reduce the memory footprint of the training script and few other bug fixes #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+67
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y using --lazy flag
svlandeg
approved these changes
Dec 24, 2019
Collaborator
svlandeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
Contributor
Author
|
@svlandeg done |
Collaborator
|
@EricLe-dev : apologies for the late follow-up, but did you pull the recent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Fixes #193
This Pull request addresses the following 3 problems:
.npyfiles to memory. Thus I have provided an option to load them lazily so that RAM usage does not blow up. This option can be turned on by passing a--lazyflag tolearn.py. Before this I was unable to train on the dataset (approx 8.5GB size in disk) generated using spacy'sen_core_web_lgmodel on my laptop (16GB RAM and 6GB GPU). The dataset required more than 50GB of RAM to train. After this change the memory foot print is ~5GBfor the same dataset and runs on my laptop without hiccups.spacy model.