Relax platform requirements to support macOS 13 #7
Conversation
There was a problem hiding this comment.
Pull request overview
This PR relaxes the minimum platform requirements to support macOS 13 (down from 14), along with corresponding downgrades for other Apple platforms. To enable this while preserving OAuth functionality that requires macOS 14+ (due to the @Observable macro), the PR refactors the TokenProvider.oauth enum case from taking a concrete HuggingFaceAuthenticationManager parameter to accepting a generic async closure. A platform-restricted factory method .oauth(manager:) is introduced to provide convenient creation of OAuth token providers on supported platforms.
Key Changes:
- Downgraded minimum platform versions (macOS 14→13, macCatalyst 14→16, watchOS 10→9, tvOS 17→16)
- Refactored
TokenProvider.oauthcase to use async closure pattern instead of direct manager reference - Added
@availableannotations to OAuth-related code to restrict to macOS 14+ platforms
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Package.swift | Lowered minimum platform requirements to support older OS versions |
| Sources/HuggingFace/Shared/TokenProvider.swift | Refactored OAuth enum case to use closure pattern; added factory method with availability restrictions; updated documentation |
| Sources/HuggingFace/OAuth/HuggingFaceAuthenticationManager.swift | Added @available annotations to all OAuth-related types and extensions to restrict to macOS 14+ platforms |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case .oauth: | ||
| fatalError( | ||
| "OAuth token provider requires async context. Use getToken() in an async context or switch to a synchronous provider." | ||
| ) |
There was a problem hiding this comment.
The synchronous getToken() method handles the .oauth case by throwing a fatal error, but there doesn't appear to be an async overload func getToken() async throws -> String? that properly implements the OAuth case by calling the closure. Without the async overload, OAuth functionality will be broken as the closure cannot be invoked from synchronous contexts. You need to add an async version of getToken() that handles .oauth(let getToken): by calling try await getToken().
Related to huggingface/swift-transformers#297