Skip to content

Remove unused Combine import #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove unused Combine import #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
97a535f
Remove Unused Combine
Skyline-23 Nov 16, 2025
75afcce
Replace CryptoKit to swift-crypto
Skyline-23 Nov 16, 2025
c0d2074
Update commnet
Skyline-23 Nov 16, 2025
60fd904
Revert commit to separate PR Replace CryptoKit
Skyline-23 Nov 16, 2025
6a74e1f
Update comment to pass Lint
Skyline-23 Nov 16, 2025
7edf3ac
Update comments for details
Skyline-23 Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/Hub/Downloader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@
// See LICENSE at https://github.com/huggingface/swift-coreml-diffusers/LICENSE
//

import Combine
import Foundation

/// A robust file downloader with support for resumable downloads and progress reporting.
///
/// The Downloader class handles file downloads from remote URLs with features including
/// automatic resume capability, progress tracking, speed monitoring, and retry mechanisms.
/// It supports both foreground and background download sessions for different use cases.
final class Downloader: NSObject, Sendable, ObservableObject {
final class Downloader: NSObject, Sendable {
private let destination: URL
private let incompleteDestination: URL
private let downloadResumeState: DownloadResumeState = .init()
Expand Down
7 changes: 4 additions & 3 deletions Sources/Hub/HubApi.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,9 +491,10 @@ public extension HubApi {
}
}

/// Note we go from Combine in Downloader to callback-based progress reporting
/// We'll probably need to support Combine as well to play well with Swift UI
/// (See for example PipelineLoader in swift-coreml-diffusers)
/// Downloads the file with progress tracking.
/// - Parameter progressHandler: Called with download progress (0.0-1.0) and speed in bytes/sec, if available.
/// - Returns: Local file URL (uses cached file if commit hash matches).
/// - Throws: ``EnvironmentError`` errors for file and metadata validation failures, ``Downloader.DownloadError`` errors during transfer, or ``CancellationError`` if the task is cancelled.
@discardableResult
func download(progressHandler: @escaping (Double, Double?) -> Void) async throws -> URL {
let localMetadata = try hub.readDownloadMetadata(metadataPath: metadataDestination)
Expand Down
1 change: 0 additions & 1 deletion Tests/HubTests/DownloaderTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// Created by Arda Atahan Ibis on 1/28/25.
//

import Combine
import XCTest

@testable import Hub
Expand Down