Move to moe-kernels package and switch to common MoE layer #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
force-pushed
the
feature/moe-kernels
branch
5 times, most recently
from
6098899 to
d38d6e0
Compare
Member
Author
|
The CI failure looks unrelated. |
Narsil
reviewed
Sep 13, 2024
Contributor
Narsil
left a comment
Narsil
left a comment
There was a problem hiding this comment.
LGTM.
Have you checked th tests before the PR on mixtral see if the output is the same ?
| SpeculativeHead, | ||
| get_linear, | ||
| ) | ||
| from text_generation_server.layers.moe import SparseMoELayer |
Contributor
There was a problem hiding this comment.
Can this be imported on ipex?
Member
Author
There was a problem hiding this comment.
I changed the import in text_generation_server.layers.moe.unquantized conditional on IPEX not being used (like the old code).
Member
Author
Yeah, I created the test first on the |
danieldk
force-pushed
the
feature/moe-kernels
branch
from
d38d6e0 to
c997e3f
Compare
This change introduces the new `moe-kernels` package: - Add `moe-kernels` as a dependency. - Introduce a `SparseMoELayer` module that can be used by MoE models. - Port over Mixtral and Deepseek.
danieldk
force-pushed
the
feature/moe-kernels
branch
from
c997e3f to
5726a9c
Compare
Narsil
reviewed
Sep 17, 2024
| { | ||
| "id": 369, | ||
| "logprob": -0.06585693, | ||
| "logprob": 0.0, |
Member
Author
There was a problem hiding this comment.
Also see the " me" above, and that was before the changes.
Member
Author
There was a problem hiding this comment.
Guess that's what a temperature of 0.5 does. Happens a lot though:
❯ git grep '"logprob": 0\.0,' | uniq | wc -l
33
Narsil
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change introduces the new
moe-kernelspackage:moe-kernelsas a dependency.SparseMoELayermodule that can be used by MoE models.GPTQ-Marlin support and porting DBRX is for follow-up PRs.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.