Fix failing windows #33436
Merged
Fix failing windows #33436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
verified here that it was fixing what it intends to fix: huggingface/trl#2051 |
|
Merging with offline approval from @ArthurZucker |
4 tasks
hiyouga
added a commit
to hiyouga/LLaMA-Factory
that referenced
this pull request
Sep 11, 2024
|
|
@tqangxl, the merge of the import structure was not in a release, so expediting this fix in a release doesn't necessarily make sense. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* Encoding * style
1587causalai
pushed a commit
to 1587causalai/llama_factory
that referenced
this pull request
Feb 18, 2025
stephen-nju
pushed a commit
to stephen-nju/Llmtrain
that referenced
this pull request
Mar 24, 2025
huggingface/transformers#33436 Former-commit-id: ac06b78
yoonseok312
pushed a commit
to pensieve-ai/LLaMA-Factory-vlm
that referenced
this pull request
Apr 29, 2025
huggingface/transformers#33436 Former-commit-id: ac06b78
liu-qingyuan
pushed a commit
to liu-qingyuan/LLaMA-Factory-Megafake
that referenced
this pull request
Jun 6, 2025
huggingface/transformers#33436 Former-commit-id: ac06b78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an encoding issue on Windows following the merge of the import structure refactor