Skip to content

Fix Docker images for Liger #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

Fix Docker images for Liger #4522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/trl-dev/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM pytorch/pytorch:2.8.0-cuda12.8-cudnn9-runtime
FROM pytorch/pytorch:2.8.0-cuda12.8-cudnn9-devel
Copy link
Member Author

@lewtun lewtun Nov 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if we want to use vllm in the images for e.g. GRPO, a better approach is to use the official vllm image like this:

Suggested change
FROM pytorch/pytorch:2.8.0-cuda12.8-cudnn9-devel
FROM vllm/vllm-openai:v0.10.2

Copy link
Member

@qgallouedec qgallouedec Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I don't know what to think of it right now, I've opened #4523 the meantime

RUN apt-get update && apt-get install -y git && rm -rf /var/lib/apt/lists/*
RUN pip install --upgrade pip uv
RUN uv pip install --system --no-cache "git+https://github.com/huggingface/trl.git#egg=trl[liger,peft,vlm]"
RUN uv pip install --system hf_transfer kernels liger_kernel peft trackio
RUN uv pip install --system kernels liger_kernel peft trackio
5 changes: 3 additions & 2 deletions docker/trl/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
FROM pytorch/pytorch:2.8.0-cuda12.8-cudnn9-runtime
FROM pytorch/pytorch:2.8.0-cuda12.8-cudnn9-devel
RUN apt-get update && apt-get install -y git && rm -rf /var/lib/apt/lists/*
RUN pip install --upgrade pip uv
RUN uv pip install --system trl[liger,peft,vlm] hf_transfer kernels trackio
RUN uv pip install --system trl[liger,peft,vlm] kernels trackio
Loading