fix: return non-zero exit code when collection errors occur#132
Merged
fix: return non-zero exit code when collection errors occur#132
Conversation
The run_tests() function now returns exit code 1 when there are collection errors, matching the behavior of the main CLI entry point. Previously, collection errors were displayed but execution would continue if some tests were successfully collected, potentially masking issues like test classes that inherit from enum.Enum or have syntax errors.
Benchmark Comparison ReportComparing current results against baseline from
Summary
Performance regressions detected! Legend
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_tests()function now returns exit code 1 when collection errors occurmain_cli_with_args)Test plan