Fix footer if the content is too small#4
Merged
Folyd merged 2 commits intohuhu:masterfrom Sep 20, 2021
Merged
Conversation
Folyd
requested changes
Sep 16, 2021
Member
Folyd
left a comment
Folyd
left a comment
There was a problem hiding this comment.
Thanks for the PR. Can we remove the flex style?
Comment on lines
+10
to
+12
| justify-content:space-between; | ||
| display:flex; | ||
| flex-direction:column; |
Member
There was a problem hiding this comment.
I'd like to keep the body less styled as possible, and the min-height is enough to fix this. What do you think?
Contributor
Author
There was a problem hiding this comment.
I tested locally,the behaviour is the same (wrong) without flex
Member
There was a problem hiding this comment.
You are right. I have another idea to fix this:
.body {
+ display: flex;
+ flex-direction: column;
+ min-height: 100vh;
}
.main {
+ flex-grow: 1;
}
.content {
- justify-content: center;
}
Folyd
approved these changes
Sep 20, 2021
ayrat555
added a commit
to ayrat555/el_monitorro
that referenced
this pull request
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before
after
