Skip to content

Dynamically import p-map #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreibratu merged 1 commit into from
Feb 14, 2025
Merged

Dynamically import p-map #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/eval_utils/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import cliProgress from "cli-progress";
import { Humanloop, HumanloopClient } from "index";
import _ from "lodash";
import pMap from "p-map";

import {
BooleanEvaluatorStatsResponse,
Expand Down Expand Up @@ -484,6 +483,10 @@ export async function runEval(
);
const totalDatapoints = hlDataset.datapoints!.length;
progressBar.start(totalDatapoints, 0);

// p-map is esm only since v5. Since we're targeting cjs, we need to
// import it dynamically, so it works for both cjs and esm consumers on node < 22.
const { default: pMap } = await import("p-map");
await pMap(
hlDataset.datapoints!,
async (datapoint) => {
Expand Down