Skip to content

Fix gmap grouped field data structure #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikeselander merged 5 commits into from
Mar 20, 2017
Merged

Fix gmap grouped field data structure #423

mikeselander merged 5 commits into from
Mar 20, 2017

Conversation

@dan-westall
Copy link
Contributor

@dan-westall dan-westall commented Mar 17, 2017

Fix for incorrect data structure on a existing field

Resolves #422

I have:

  • Run WordPress VIP PHPCS check and code parses without errors
  • Added any new PHPUnit tests
  • Run PHPUnit and all tests are passing after adding any necessary new tests
  • Tested feature/bugfix on single and multisite install

@mikeselander

@mikeselander mikeselander mentioned this pull request Mar 20, 2017
Open
@mikeselander mikeselander merged commit 8e99443 into develop Mar 20, 2017
@mikeselander mikeselander deleted the 422-gmap-update-values branch March 20, 2017 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeselander mikeselander Awaiting requested review from mikeselander

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to save gmap field when field is within a group

3 participants

@dan-westall @mikeselander