Add data to notification#90
Merged
Merged
Conversation
Member
Author
|
Oh another thing I added here is a timestamp, which I think would be useful to include in this. |
roborourke
reviewed
Jul 8, 2019
shadyvb
approved these changes
Jul 9, 2019
Contributor
shadyvb
left a comment
shadyvb
left a comment
There was a problem hiding this comment.
Could use a new type property while we’re here, otherwise no blockers, will need more work on sanitisation once merged.
| $data_sanitization_fn = apply_filters( 'hm.workflows.action.data.sanitizer', 'sanitize_text_field' ); | ||
|
|
||
| if ( ! is_callable( $data_sanitization_fn ) ) { | ||
| if ( ! $data_sanitization_fn || ! is_callable( $data_sanitization_fn ) ) { |
Contributor
There was a problem hiding this comment.
This can probably make use of the enhancements Rob suggested, where a more thorough function is checking object items based on the value type. It needs some work on the original ticket anyway, and probably then some.
Contributor
|
Continuing work on this as part of #88, will tackle all the feedback here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is some POC code to add data to the notification itself (instead of or in addition to action data...)
Mostly just getting my head around the internals of this plugin so needs a bit more work - but wanted to share.